-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent tab reordering while elevated #4874
Merged
The head ref may contain hidden characters: "dev/duhowett/\u203E"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a platform limitation that causes us to crash when we rearrange tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the drag hosting process, but that process is running at a different IL than us. For now, we're disabling elevated drag. Fixes #3581
zadjii-msft
approved these changes
Mar 10, 2020
carlos-zamora
approved these changes
Mar 11, 2020
miniksa
approved these changes
Mar 11, 2020
miniksa
added
the
AutoMerge
Marked for automatic merge by the bot when requirements are met
label
Mar 11, 2020
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/duhowett/‾
branch
March 11, 2020 15:52
Hah! Interesting side effect. |
abhijeetviswam
pushed a commit
to abhijeetviswam/terminal
that referenced
this pull request
Mar 12, 2020
There's a platform limitation that causes us to crash when we rearrange tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the drag hosting process, but that process is running at a different IL than us. For now, we're disabling elevated drag. Fixes microsoft#3581
🎉 Handy links: |
This was referenced Jul 13, 2020
Closed
ghost
pushed a commit
that referenced
this pull request
Sep 16, 2021
When we're elevated, we disable drag/dropping tabs when elevated, because of a platform limitation that causes the app to _crash_ (see #4874). However, if the user has UAC disabled, this actually works alright. So I'm adding it back in that case. I'm not positive if this is the best way to check if UAC is disabled, but normally, you'll get a [`TokenElevationTypeFull`] when elevated, not `TokenElevationTypeDefault`. If the app is elevated, but there's not a split token, that kinda implies there's no user account separation. If I'm wrong, it's just code, let's replace this with something that does work. ## Validation Steps Performed Booted up a Win10 VM, set `enableLUA` to `0`, rebooted, and checked if this exploded. It didn't. References #4874 References #3581 Work done in pursuit of #11096 Closes #7754 [`TokenElevationTypeFull`]: https://docs.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_elevation_type
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AutoMerge
Marked for automatic merge by the bot when requirements are met
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a platform limitation that causes us to crash when we rearrange
tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the
drag hosting process, but that process is running at a different IL than
us.
For now, we're disabling elevated drag.
Fixes #3581